Get node_id_per_cell_vector using connectivity object

Tried to get values from a specialized access function according to the type of
items but does not always compile depending on the placement of the called
function.
If the template function call is operated into the connectivity class,
everything works like a charm, but using it outside leads to weird compilation
issue. Is it a compiler issue?

src/mesh/Connectivity1D.hpp

@@ -7,6 +7,7 @@
 #include <TinyVector.hpp>
 #include <ConnectivityUtils.hpp>
 
+#include <TypeOfItem.hpp>
 #include <RefId.hpp>
 #include <RefNodeList.hpp>
 
@@ -26,6 +27,11 @@ public:
   // a local node in a cell
   ConnectivityMatrix m_node_id_per_cell_matrix;
 
+  ConnectivityMatrix subItemIdPerItemMatrix() const
+  {
+    return m_node_id_per_cell_matrix;
+  }
+
  private:
   std::vector<RefNodeList> m_ref_node_list;
 

src/mesh/Connectivity2D.hpp

@@ -10,6 +10,7 @@
 #include <map>
 #include <algorithm>
 
+#include <TypeOfItem.hpp>
 #include <RefId.hpp>
 #include <RefNodeList.hpp>
 #include <RefFaceList.hpp>
@@ -33,6 +34,11 @@ class Connectivity2D
   // a local node in a cell
   ConnectivityMatrix m_node_id_per_cell_matrix;
 
+  inline ConnectivityMatrix subItemIdPerItemMatrix() const
+  {
+    return m_node_id_per_cell_matrix;
+  }
+
  private:
   std::vector<RefFaceList> m_ref_face_list;
   std::vector<RefNodeList> m_ref_node_list;

src/mesh/Connectivity3D.hpp

@@ -12,6 +12,7 @@
 #include <algorithm>
 
 #include <RefId.hpp>
+#include <TypeOfItem.hpp>
 #include <RefNodeList.hpp>
 #include <RefFaceList.hpp>
 
@@ -41,6 +42,11 @@ public:
   // a local node in a cell
   ConnectivityMatrix m_node_id_per_cell_matrix;
 
+  inline ConnectivityMatrix subItemIdPerItemMatrix() const
+  {
+    return m_node_id_per_cell_matrix;
+  }
+
 private:
   std::vector<RefFaceList> m_ref_face_list;
   std::vector<RefNodeList> m_ref_node_list;

src/mesh/MeshData.hpp

@@ -203,9 +203,9 @@ class MeshData
 
   MeshData(const MeshType& mesh)
       : m_mesh(mesh),
-        m_Cjr(mesh.connectivity().m_node_id_per_cell_matrix),
-        m_ljr(mesh.connectivity().m_node_id_per_cell_matrix),
-        m_njr(mesh.connectivity().m_node_id_per_cell_matrix),
+        m_Cjr(mesh.connectivity()),
+        m_ljr(mesh.connectivity()),
+        m_njr(mesh.connectivity()),
         m_xj("xj", mesh.numberOfCells()),
         m_Vj("Vj", mesh.numberOfCells())
   {

src/mesh/TypeOfItem.hpp

+#ifndef TYPE_OF_ITEM_HPP
+#define TYPE_OF_ITEM_HPP
+
+enum class TypeOfItem {
+  node = 0,
+  edge = 1,
+  face = 2,
+  cell = 3
+};
+
+#endif // TYPE_OF_ITEM_HPP

src/scheme/AcousticSolver.hpp

@@ -255,10 +255,10 @@ class AcousticSolver
         m_connectivity(m_mesh.connectivity()),
         m_boundary_condition_list(bc_list),
         m_br("br", m_mesh.numberOfNodes()),
-        m_Ajr(m_connectivity.m_node_id_per_cell_matrix),
+        m_Ajr(m_connectivity),
         m_Ar("Ar", m_mesh.numberOfNodes()),
         m_inv_Ar("inv_Ar", m_mesh.numberOfNodes()),
-        m_Fjr(m_connectivity.m_node_id_per_cell_matrix),
+        m_Fjr(m_connectivity),
         m_ur("ur", m_mesh.numberOfNodes()),
         m_rhocj("rho_c", m_mesh.numberOfCells()),
         m_Vj_over_cj("Vj_over_cj", m_mesh.numberOfCells())

src/scheme/SubItemValuePerItem.hpp

@@ -2,18 +2,12 @@
 #define SUBITEM_VALUE_PER_ITEM_HPP
 
 #include <Kokkos_StaticCrsGraph.hpp>
+#include <TypeOfItem.hpp>
 
 #warning should not stand in the scheme directory
 
 typedef Kokkos::StaticCrsGraph<unsigned int, Kokkos::HostSpace> ConnectivityMatrix;
 
-enum class TypeOfItem {
-  node,
-  edge,
-  face,
-  cell
-};
-
 template <typename DataType,
           TypeOfItem SubItemType,
           TypeOfItem ItemType>
@@ -166,8 +160,10 @@ class SubItemValuePerItem
   }
 
   SubItemValuePerItem() = default;
-  SubItemValuePerItem(const ConnectivityMatrix& subitem_id_per_item_matrix)
-      : m_subitem_id_per_item_matrix(subitem_id_per_item_matrix),
+
+  template <typename ConnectivityType>
+  SubItemValuePerItem(const ConnectivityType& connectivity)
+      : m_subitem_id_per_item_matrix(connectivity.subItemIdPerItemMatrix()),
         m_values("values", m_subitem_id_per_item_matrix.entries.extent(0))
   {
     ;
@@ -176,7 +172,6 @@ class SubItemValuePerItem
   ~SubItemValuePerItem() = default;
 };
 
-
 template <typename DataType>
 using NodeValuePerCell = SubItemValuePerItem<DataType, TypeOfItem::node, TypeOfItem::cell>;