Add tests for MeshLineNodeBoundary

src/mesh/MeshLineNodeBoundary.cpp

@@ -15,21 +15,21 @@ MeshLineNodeBoundary<Dimension>::_checkBoundaryIsLine(const TinyVector<Dimension
 
   const NodeValue<const Rd>& xr = mesh.xr();
 
-  Rdxd P = Rdxd{identity} - tensorProduct(direction, direction);
+  const Rdxd P = Rdxd{identity} - tensorProduct(direction, direction);
 
   bool is_bad = false;
-  parallel_for(this->m_node_list.size(), [=, &is_bad](int node_id) {
-    const Rd& x    = xr[this->m_node_list[node_id]];
-    const Rd delta = x - origin;
-    if (dot(P * delta, direction) > 1E-13 * length) {
+  parallel_for(this->m_node_list.size(), [=, &is_bad](int i_node) {
+    const Rd& x    = xr[this->m_node_list[i_node]];
+    const Rd delta = P * (x - origin);
+    if (dot(delta, delta) > 1E-13 * length) {
       is_bad = true;
     }
   });
 
   if (parallel::allReduceOr(is_bad)) {
     std::ostringstream ost;
-    ost << "invalid boundary " << rang::fgB::yellow << this->m_boundary_name << rang::style::reset
-        << ": boundary is not a line!";
+    ost << "invalid boundary \"" << rang::fgB::yellow << this->m_boundary_name << rang::style::reset
+        << "\": boundary is not a line!";
     throw NormalError(ost.str());
   }
 }
@@ -48,8 +48,8 @@ MeshLineNodeBoundary<2>::_getDirection(const Mesh<Connectivity<2>>& mesh)
 
   if (xmin == xmax) {
     std::ostringstream ost;
-    ost << "invalid boundary " << rang::fgB::yellow << this->m_boundary_name << rang::style::reset
-        << ": unable to compute direction";
+    ost << "invalid boundary \"" << rang::fgB::yellow << this->m_boundary_name << rang::style::reset
+        << "\": unable to compute direction";
     throw NormalError(ost.str());
   }
 
@@ -92,6 +92,12 @@ MeshLineNodeBoundary<3>::_getDirection(const Mesh<Connectivity<3>>& mesh)
   }
 
   const double length = l2Norm(direction);
+  if (length == 0) {
+    std::ostringstream ost;
+    ost << "invalid boundary \"" << rang::fgB::yellow << this->m_boundary_name << rang::style::reset
+        << "\": unable to compute direction";
+    throw NormalError(ost.str());
+  }
   direction *= 1. / length;
 
   this->_checkBoundaryIsLine(direction, xmin, length, mesh);

tests/CMakeLists.txt

@@ -178,6 +178,7 @@ add_executable (mpi_unit_tests
   test_MeshFaceBoundary.cpp
   test_MeshFlatFaceBoundary.cpp
   test_MeshFlatNodeBoundary.cpp
+  test_MeshLineNodeBoundary.cpp
   test_MeshNodeBoundary.cpp
   test_Messenger.cpp
   test_OFStream.cpp