Merge branch 'develop' into feature/checkpointing

src/utils/Messenger.cpp

@@ -28,7 +28,7 @@ Messenger::destroy()
   }
 }
 
-Messenger::Messenger([[maybe_unused]] int& argc, [[maybe_unused]] char* argv[], bool parallel_output)
+Messenger::Messenger([[maybe_unused]] int& argc, [[maybe_unused]] char* argv[], [[maybe_unused]] bool parallel_output)
 {
 #ifdef PUGS_HAS_MPI
   MPI_Init(&argc, &argv);

src/utils/ReproducibleSumMPI.hpp

@@ -48,6 +48,9 @@ allReduceReproducibleSum(const ReproducibleScalarSum<ArrayT, BoolArrayT>& s)
   BinType sum_bin = zero;
   MPI_Allreduce(&local_bin, &sum_bin, 1, mpi_bin_type, mpi_bin_sum_op, parallel::Messenger::getInstance().comm());
 
+  MPI_Type_free(&mpi_bin_type);
+  MPI_Op_free(&mpi_bin_sum_op);
+
   return sum_bin;
 }
 
@@ -73,6 +76,9 @@ allReduceReproducibleSum(const ReproducibleTinyVectorSum<ArrayT, BoolArrayT>& s)
   BinType sum_bin = zero;
   MPI_Allreduce(&local_bin, &sum_bin, 1, mpi_bin_type, mpi_bin_sum_op, parallel::Messenger::getInstance().comm());
 
+  MPI_Op_free(&mpi_bin_sum_op);
+  MPI_Type_free(&mpi_bin_type);
+
   return sum_bin;
 }
 
@@ -98,6 +104,9 @@ allReduceReproducibleSum(const ReproducibleTinyMatrixSum<ArrayT, BoolArrayT>& s)
   BinType sum_bin = zero;
   MPI_Allreduce(&local_bin, &sum_bin, 1, mpi_bin_type, mpi_bin_sum_op, parallel::Messenger::getInstance().comm());
 
+  MPI_Op_free(&mpi_bin_sum_op);
+  MPI_Type_free(&mpi_bin_type);
+
   return sum_bin;
 }
 

src/utils/ReproducibleSumUtils.hpp

@@ -168,7 +168,7 @@ class ReproducibleScalarSum
   PUGS_INLINE static void
   _update(const DataType& m, Bin& bin) noexcept(NO_ASSERT)
   {
-    Assert(m > 0);
+    Assert(m >= 0);
 
     using namespace reproducible_sum_utils;
     if (m >= std::pow(DataType{2}, W - 1.) * ulp(bin.S[0])) {