Skip to content
Snippets Groups Projects
Commit c355bd93 authored by Stéphane Del Pino's avatar Stéphane Del Pino
Browse files

Get ride of Kokkos::StaticCrsGraph (Fixes #22) in ConnectivityMatrix

Also change the semantic/implementation of sub-Array and sub-Table
views. One does not use anymore Kokkos' subView which seems to be very
expensive (2 to 3 times the cost for the Lagrangian acoustic solver if
one uses subView for connectivity: lists of sub-items). It looks like
the over cost is related to the memory management (here the reference
counting).

Sub-Array and sub-Table view are coarsely "embedded raw
pointers" (which may not be safe as it is the case in
Kokkos::StaticCrsGraph). However we tried to reduce the risk of having
a view on a destroyed Array/Table by forbidding copy constructors.

ConnectivityMatrix and ItemToItemMatrix still require refactoring. For
instance it would be natural for ItemToItemMatrix  to be replaced by
the appropriate SubItemValuePerValue<ItemId>.
parent 4a973e02
No related branches found
No related tags found
1 merge request!133Simplify access functions to the number of items
Showing
with 692 additions and 219 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment