-
- Downloads
Get ride of Kokkos::StaticCrsGraph (Fixes #22) in ConnectivityMatrix
Also change the semantic/implementation of sub-Array and sub-Table views. One does not use anymore Kokkos' subView which seems to be very expensive (2 to 3 times the cost for the Lagrangian acoustic solver if one uses subView for connectivity: lists of sub-items). It looks like the over cost is related to the memory management (here the reference counting). Sub-Array and sub-Table view are coarsely "embedded raw pointers" (which may not be safe as it is the case in Kokkos::StaticCrsGraph). However we tried to reduce the risk of having a view on a destroyed Array/Table by forbidding copy constructors. ConnectivityMatrix and ItemToItemMatrix still require refactoring. For instance it would be natural for ItemToItemMatrix to be replaced by the appropriate SubItemValuePerValue<ItemId>.
parent
4a973e02
No related branches found
No related tags found
Showing
- src/mesh/ConnectivityComputer.cpp 13 additions, 13 deletionssrc/mesh/ConnectivityComputer.cpp
- src/mesh/ConnectivityMatrix.hpp 33 additions, 25 deletionssrc/mesh/ConnectivityMatrix.hpp
- src/mesh/ItemArray.hpp 1 addition, 1 deletionsrc/mesh/ItemArray.hpp
- src/mesh/ItemArrayUtils.hpp 3 additions, 3 deletionssrc/mesh/ItemArrayUtils.hpp
- src/mesh/ItemToItemMatrix.hpp 18 additions, 28 deletionssrc/mesh/ItemToItemMatrix.hpp
- src/mesh/SubItemArrayPerItem.hpp 26 additions, 31 deletionssrc/mesh/SubItemArrayPerItem.hpp
- src/mesh/SubItemArrayPerItemUtils.hpp 5 additions, 5 deletionssrc/mesh/SubItemArrayPerItemUtils.hpp
- src/mesh/SubItemValuePerItem.hpp 16 additions, 16 deletionssrc/mesh/SubItemValuePerItem.hpp
- src/mesh/SubItemValuePerItemUtils.hpp 3 additions, 3 deletionssrc/mesh/SubItemValuePerItemUtils.hpp
- src/output/VTKWriter.cpp 1 addition, 1 deletionsrc/output/VTKWriter.cpp
- src/scheme/DiscreteFunctionP0Vector.hpp 12 additions, 3 deletionssrc/scheme/DiscreteFunctionP0Vector.hpp
- src/utils/Array.hpp 56 additions, 15 deletionssrc/utils/Array.hpp
- src/utils/Table.hpp 179 additions, 31 deletionssrc/utils/Table.hpp
- tests/test_Array.cpp 63 additions, 2 deletionstests/test_Array.cpp
- tests/test_ItemArray.cpp 2 additions, 2 deletionstests/test_ItemArray.cpp
- tests/test_ItemArrayUtils.cpp 36 additions, 36 deletionstests/test_ItemArrayUtils.cpp
- tests/test_Table.cpp 225 additions, 4 deletionstests/test_Table.cpp
Loading
Please register or sign in to comment