Update ASTSymbolTableBuilder tests to take functions into account

src/language/ASTSymbolTableBuilder.cpp

@@ -46,23 +46,24 @@ ASTSymbolTableBuilder::buildSymbolTable(ASTNode& n, std::shared_ptr<SymbolTable>
           throw parse_error(error_message.str(), std::vector{n.begin()});
         }
       } else if (n.is_type<language::function_definition>()) {
-        auto register_symbol = [&](const std::string& symbol) {
-          auto [i_symbol, success] = symbol_table->add(symbol, n.children[0]->begin());
+        auto register_symbol = [&](const ASTNode& argument_node) {
+          auto [i_symbol, success] = symbol_table->add(argument_node.string(), argument_node.begin());
           if (not success) {
             std::ostringstream error_message;
-            error_message << "symbol '" << rang::fg::red << symbol << rang::fg::reset << "' was already defined!";
-            throw parse_error(error_message.str(), std::vector{n.begin()});
+            error_message << "symbol '" << rang::fg::red << argument_node.string() << rang::fg::reset
+                          << "' was already defined!";
+            throw parse_error(error_message.str(), std::vector{argument_node.begin()});
           }
           // Symbols will be initialized at call
           i_symbol->attributes().setIsInitialized();
         };
 
         if (n.children[0]->is_type<language::name>()) {
-          register_symbol(n.children[0]->string());
+          register_symbol(*n.children[0]);
         } else {   // treats the case of list of parameters
           Assert(n.children[0]->is_type<language::name_list>());
           for (auto& child : n.children[0]->children) {
-            register_symbol(child->string());
+            register_symbol(*child);
           }
         }
       } else if (n.is_type<language::name>()) {

tests/test_ASTSymbolTableBuilder.cpp

@@ -21,6 +21,8 @@ N n = 2;
     ASTSymbolTableBuilder{*ast};
   }
 
+  SECTION("errors")
+  {
     SECTION("Undeclared symbol")
     {
       std::string_view data = R"(
@@ -45,4 +47,30 @@ N n = 1;
 
       REQUIRE_THROWS_AS(ASTSymbolTableBuilder{*ast}, parse_error);
     }
+
+    SECTION("Re-declared symbol (function)")
+    {
+      std::string_view data = R"(
+N f;
+let f : R -> R, x -> 1;
+)";
+
+      string_input input{data, "test.pgs"};
+      auto ast = ASTBuilder::build(input);
+
+      REQUIRE_THROWS_AS(ASTSymbolTableBuilder{*ast}, parse_error);
+    }
+
+    SECTION("Re-declared parameter (function)")
+    {
+      std::string_view data = R"(
+let f : R*R*N -> R, (x,y,x) -> 1;
+)";
+
+      string_input input{data, "test.pgs"};
+      auto ast = ASTBuilder::build(input);
+
+      REQUIRE_THROWS_AS(ASTSymbolTableBuilder{*ast}, parse_error);
+    }
+  }
 }