Fix a bunch of clazy warnings and ignore false positive

src/mesh/CartesianMeshBuilder.cpp

@@ -8,15 +8,16 @@
 #include <utils/Messenger.hpp>
 
 template <size_t Dimension>
-void
+inline void
 CartesianMeshBuilder::_buildBoundaryNodeList(const TinyVector<Dimension, uint64_t>&, ConnectivityDescriptor&)
 {
   static_assert(Dimension <= 3, "unexpected dimension");
 }
 
 template <>
-void
-CartesianMeshBuilder::_buildBoundaryNodeList(const TinyVector<1, uint64_t>& cell_size,
+inline void
+CartesianMeshBuilder::_buildBoundaryNodeList(
+  const TinyVector<1, uint64_t>& cell_size,   // clazy:exclude=function-args-by-value
   ConnectivityDescriptor& descriptor)
 {
   {   // xmin
@@ -34,12 +35,13 @@ CartesianMeshBuilder::_buildBoundaryNodeList(const TinyVector<1, uint64_t>& cell
 
 template <>
 void
-CartesianMeshBuilder::_buildBoundaryNodeList(const TinyVector<2, uint64_t>& cell_size,
+CartesianMeshBuilder::_buildBoundaryNodeList(
+  const TinyVector<2, uint64_t>& cell_size,   // clazy:exclude=function-args-by-value
   ConnectivityDescriptor& descriptor)
 {
   const TinyVector<2, uint64_t> node_size{cell_size[0] + 1, cell_size[1] + 1};
 
-  const auto node_number = [&](const TinyVector<2, uint64_t>& node_logic_id) {
+  const auto node_number = [&](const TinyVector<2, uint64_t> node_logic_id) {
     return node_logic_id[0] * node_size[1] + node_logic_id[1];
   };
 
@@ -247,10 +249,11 @@ CartesianMeshBuilder::_buildBoundaryFaceList(const TinyVector<Dimension, uint64_
 
 template <>
 void
-CartesianMeshBuilder::_buildBoundaryFaceList(const TinyVector<2, uint64_t>& cell_size,
+CartesianMeshBuilder::_buildBoundaryFaceList(
+  const TinyVector<2, uint64_t>& cell_size,   // clazy:exclude=function-args-by-value
   ConnectivityDescriptor& descriptor)
 {
-  const auto cell_number = [&](const TinyVector<2, uint64_t>& cell_logic_id) {
+  const auto cell_number = [&](const TinyVector<2, uint64_t> cell_logic_id) {
     return cell_logic_id[0] * cell_size[1] + cell_logic_id[1];
   };
 
@@ -422,9 +425,10 @@ CartesianMeshBuilder::_buildBoundaryFaceList(const TinyVector<3, uint64_t>& cell
 
 template <>
 void
-CartesianMeshBuilder::_buildCartesianMesh(const TinyVector<1>& a,
-                                          const TinyVector<1>& b,
-                                          const TinyVector<1, uint64_t>& cell_size)
+CartesianMeshBuilder::_buildCartesianMesh(
+  const TinyVector<1>& a,                     // clazy:exclude=function-args-by-value
+  const TinyVector<1>& b,                     // clazy:exclude=function-args-by-value
+  const TinyVector<1, uint64_t>& cell_size)   // clazy:exclude=function-args-by-value
 {
   const size_t number_of_cells = cell_size[0];
   const size_t number_of_nodes = cell_size[0] + 1;
@@ -476,9 +480,10 @@ CartesianMeshBuilder::_buildCartesianMesh(const TinyVector<1>& a,
 
 template <>
 void
-CartesianMeshBuilder::_buildCartesianMesh(const TinyVector<2>& a,
-                                          const TinyVector<2>& b,
-                                          const TinyVector<2, uint64_t>& cell_size)
+CartesianMeshBuilder::_buildCartesianMesh(
+  const TinyVector<2>& a,                     // clazy:exclude=function-args-by-value
+  const TinyVector<2>& b,                     // clazy:exclude=function-args-by-value
+  const TinyVector<2, uint64_t>& cell_size)   // clazy:exclude=function-args-by-value
 {
   constexpr size_t Dimension = 2;
 
@@ -507,7 +512,7 @@ CartesianMeshBuilder::_buildCartesianMesh(const TinyVector<2>& a,
     return TinyVector<Dimension, uint64_t>{r0, r1};
   };
 
-  const auto node_number = [&](const TinyVector<Dimension, uint64_t>& node_logic_id) {
+  const auto node_number = [&](const TinyVector<Dimension, uint64_t> node_logic_id) {
     return node_logic_id[0] * node_size[1] + node_logic_id[1];
   };