From bbe0a97f1e035081662ff098927b6a79c01bb572 Mon Sep 17 00:00:00 2001
From: Stephane Del Pino <stephane.delpino44@gmail.com>
Date: Mon, 18 Jul 2022 00:22:43 +0200
Subject: [PATCH] Fix a bunch of clang warnings (including a dangerous one)
---
src/language/ast/ASTBuilder.cpp | 2 +-
src/language/node_processor/FunctionProcessor.hpp | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/language/ast/ASTBuilder.cpp b/src/language/ast/ASTBuilder.cpp
index 252e0d44e..476c30201 100644
--- a/src/language/ast/ASTBuilder.cpp
+++ b/src/language/ast/ASTBuilder.cpp
@@ -54,7 +54,7 @@ struct ASTBuilder::rearrange_pre_unary_op : TAO_PEGTL_NAMESPACE::parse_tree::app
{
template <typename... States>
static void
- transform(std::unique_ptr<ASTNode>& n, States&&... st)
+ transform(std::unique_ptr<ASTNode>& n, States&&...)
{
if (n->children.size() == 1) {
n = std::move(n->children.back());
diff --git a/src/language/node_processor/FunctionProcessor.hpp b/src/language/node_processor/FunctionProcessor.hpp
index 86742e170..bc8c3c0bd 100644
--- a/src/language/node_processor/FunctionProcessor.hpp
+++ b/src/language/node_processor/FunctionProcessor.hpp
@@ -26,7 +26,8 @@ class FunctionExpressionProcessor final : public INodeProcessor
} else if constexpr (std::is_same_v<ExpressionValueType, ZeroType>) {
return ReturnType{ZeroType::zero};
} else if constexpr (std::is_convertible_v<ExpressionValueType, ReturnType>) {
- const ExpressionValueType& v = std::get<ExpressionValueType>(m_function_expression.execute(exec_policy));
+ auto expression_value = m_function_expression.execute(exec_policy);
+ const ExpressionValueType& v = std::get<ExpressionValueType>(expression_value);
if constexpr (std::is_same_v<ReturnType, uint64_t> and std::is_same_v<ExpressionValueType, int64_t>) {
if (v < 0) {
throw std::domain_error("trying to convert negative value (" + stringify(v) + ")");
--
GitLab