From 5e82adcc7e8f8e49e28996658a2df9398b647876 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Del=20Pino?= <stephane.delpino44@gmail.com> Date: Fri, 18 Feb 2022 00:04:19 +0100 Subject: [PATCH] Remove global scoping for htons and ntohs calls On Ubuntu 18.04, it seems that these calls can be problematic (don't really know why). --- src/utils/Socket.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/utils/Socket.cpp b/src/utils/Socket.cpp index 3582e359b..617f6e167 100644 --- a/src/utils/Socket.cpp +++ b/src/utils/Socket.cpp @@ -63,7 +63,7 @@ class Socket::Internals int portNumber() const { - return ::ntohs(m_address.sin_port); + return ntohs(m_address.sin_port); } int @@ -180,7 +180,7 @@ connectServerSocket(const std::string& server_name, int port_number) ::memcpy(reinterpret_cast<char*>(&serv_addr.sin_addr.s_addr), reinterpret_cast<char*>(server->h_addr), server->h_length); - serv_addr.sin_port = ::htons(port_number); + serv_addr.sin_port = htons(port_number); if (::connect(socket_internals.m_socket_fd, reinterpret_cast<sockaddr*>(&serv_addr), sizeof(serv_addr))) { throw NormalError(strerror(errno)); -- GitLab