From 557929a0caed3573656671d09707ebc69e291cde Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Del=20Pino?= <stephane.delpino44@gmail.com>
Date: Fri, 11 Jun 2021 11:28:32 +0200
Subject: [PATCH] Improve error messages and add bound violation tests
---
src/analysis/Polynomial1D.hpp | 4 ++--
tests/test_Polynomial1D.cpp | 11 ++++++++++-
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/analysis/Polynomial1D.hpp b/src/analysis/Polynomial1D.hpp
index 20d4cf90a..894ffa8d8 100644
--- a/src/analysis/Polynomial1D.hpp
+++ b/src/analysis/Polynomial1D.hpp
@@ -202,14 +202,14 @@ class [[nodiscard]] Polynomial1D
PUGS_INLINE
double& coefficient(const size_t i)
{
- Assert(i < m_coefficients.size());
+ Assert(i < m_coefficients.size(), "invalid coefficient number");
return m_coefficients[i];
}
PUGS_INLINE
const double& coefficient(const size_t i) const
{
- Assert(i < m_coefficients.size());
+ Assert(i < m_coefficients.size(), "invalid coefficient number");
return m_coefficients[i];
}
diff --git a/tests/test_Polynomial1D.cpp b/tests/test_Polynomial1D.cpp
index 110cfadf7..cecd35b36 100644
--- a/tests/test_Polynomial1D.cpp
+++ b/tests/test_Polynomial1D.cpp
@@ -254,6 +254,15 @@ TEST_CASE("Polynomial1D", "[analysis]")
}
#ifndef NDEBUG
- SECTION("checking for bounds validation") {}
+ SECTION("checking for bounds validation")
+ {
+ Polynomial1D p({-1, 0, 0, 1});
+ REQUIRE_THROWS_AS(p.coefficient(4), AssertError);
+
+ const Polynomial1D q({-1, 0, 0, 1});
+ REQUIRE_THROWS_AS(q.coefficient(4), AssertError);
+
+ REQUIRE_THROWS_AS(Polynomial1D{std::vector<double>{}}, AssertError);
+ }
#endif // NDEBUG
}
--
GitLab