From 1143c1117fd6da93493b5c72db620cdb85229bef Mon Sep 17 00:00:00 2001
From: Stephane Del Pino <stephane.delpino44@gmail.com>
Date: Tue, 30 Jul 2019 10:03:27 +0200
Subject: [PATCH] Remove useless tests

These tests where unreachable:
- they were associated to declarations which are now completely removed from the
AST, or
- they were already treated (root-node)
---
 src/language/ASTNodeExpressionBuilder.cpp | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/language/ASTNodeExpressionBuilder.cpp b/src/language/ASTNodeExpressionBuilder.cpp
index 5c07d1d5e..c1a1fb8ac 100644
--- a/src/language/ASTNodeExpressionBuilder.cpp
+++ b/src/language/ASTNodeExpressionBuilder.cpp
@@ -324,11 +324,8 @@ class OStreamObject final : public INodeProcessor
 void
 ASTNodeExpressionBuilder::_buildExpression(ASTNode& n)
 {
-  if (n.is_root() or n.is<language::bloc>()) {
+  if (n.is<language::bloc>()) {
     n.m_node_processor = std::make_unique<ASTNodeList>(n);
-  } else if (n.is<language::declaration>()) {
-    n.m_node_processor = std::make_unique<NoProcess>();
-
   } else if ((n.is<language::eq_op>() or n.is<language::multiplyeq_op>() or n.is<language::divideeq_op>() or
               n.is<language::pluseq_op>() or n.is<language::minuseq_op>())) {
     ASTNodeAffectationExpressionBuilder{n};
@@ -357,17 +354,12 @@ ASTNodeExpressionBuilder::_buildExpression(ASTNode& n)
              n.is<language::not_eq_op>()) {
     ASTNodeBinaryOperatorExpressionBuilder{n};
 
-  } else if (n.is<language::B_set>()) {
-  } else if (n.is<language::N_set>()) {
-  } else if (n.is<language::Z_set>()) {
-  } else if (n.is<language::string_type>()) {
   } else if (n.is<language::cout_kw>()) {
     n.m_node_processor = std::make_unique<OStreamObject>(n, std::cout);
   } else if (n.is<language::cerr_kw>()) {
     n.m_node_processor = std::make_unique<OStreamObject>(n, std::cerr);
   } else if (n.is<language::clog_kw>()) {
     n.m_node_processor = std::make_unique<OStreamObject>(n, std::clog);
-  } else if (n.is<language::R_set>()) {
   } else if (n.is<language::if_statement>()) {
     n.m_node_processor = std::make_unique<IfStatement>(n);
   } else if (n.is<language::statement_bloc>()) {
-- 
GitLab